Skip to content

Comments

Make flog an importable package#49

Open
chaudum wants to merge 2 commits intomingrammer:masterfrom
chaudum:importable-package
Open

Make flog an importable package#49
chaudum wants to merge 2 commits intomingrammer:masterfrom
chaudum:importable-package

Conversation

@chaudum
Copy link

@chaudum chaudum commented Nov 22, 2021

There are cases where you want to generate log lines directly in your application. Therefore it is necessary to make the module github.com/mingrammer/flog importable in other projects.

Moving the code that should be importable out of the main package into its own will allow others to use import flog.

Signed-off-by: Christian Haudum christian.haudum@gmail.com

chaudum added 2 commits April 19, 2022 13:26
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
@chaudum chaudum force-pushed the importable-package branch from 92153be to 61377d1 Compare April 19, 2022 11:30
Copy link
Owner

@mingrammer mingrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mingrammer
Copy link
Owner

Please resolve the conflict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants