修复两处手机号格式校验的问题 #11
Open
修复两处手机号格式校验的问题 #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
现象
这是在登录明道云的时候偶然发现的：
修改理由
iti.isValidNumber()看着是 @mdfe/intl-tel-input 提供的校验能力。我看它底层的 utils.js 也是基于 libphonenumber 实现的，可能确实就是这个底层库有问题吧，但后面的specialTelVerify()是能正常校验的。所以我认为
src/pages/accountLogin/redux/actions.js#L133/isTelRule这里不应该用&&逻辑，而应该用||逻辑。还有一处使用
specialTelVerify()的地方也是同理，我也顺便改了。如果我上面想的不对的话还烦请指出并关闭PR，谢谢~