if we set resetTimerAfterFinish to true, we should call it before calling delegate #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuxuan30
force-pushed
the
resetAfterFinish
branch
from
9ea83d5 to
dc3d0fc
Compare
…ling delegate because reset will update the label, and if the user change the label in the delegate, it will be override by the reset, which seems not good
liuxuan30
force-pushed
the
resetAfterFinish
branch
from
dc3d0fc to
6bc62e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if we set resetTimerAfterFinish to true, we should call it before calling delegate
because reset will update the label, and if the user change the label in the delegate, it will be override by the reset, which seems not good
@mineschan Have a full review, because I am new to this project, I might not see the big picture.