Tests: Avoid hardcoded fn selectors #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgalende
commented
Nov 16, 2025
facuspagnuolo
previously approved these changes
Nov 25, 2025
Member
facuspagnuolo
left a comment
facuspagnuolo
left a comment
There was a problem hiding this comment.
Yes, let's add the ERC20 abi when using it in the tests to stay consistent with the proposed practice
lgalende
dismissed
facuspagnuolo’s stale review
The base branch was changed.
lgalende
force-pushed
the
tests/avoid_hardcoded_fn_selectors
branch
from
4c9add5 to
9a6ddc9
Compare
facuspagnuolo
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.