feat: query_data, query_spec types #1398
Conversation
🦋 Changeset detectedLatest commit: 5fa905f The changes in this PR will be included in the next version bump. This PR includes changesets to release 28 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Summary of ChangesHello @AStaroverov, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a robust and structured type system for defining data queries and expressions within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces new types for representing queries at a 'data' and 'spec' layer, which is a good step towards a more structured query system. My review focuses on improving the clarity and maintainability of these new type definitions. I've identified a critical bug in spec.ts related to type definitions that will cause compilation errors, and I've provided a fix. Additionally, I've suggested several refactorings for discriminated unions to make them more robust and easier to work with, and recommended formatting changes for better readability.
| export interface QuerySortEntryData { | ||
| axisOrColumn: SelectorData; | ||
| ascending: boolean; | ||
| nullsFirst?: boolean | null; |
There was a problem hiding this comment.
make sure pframes-rs use default false, most likely it is true by default, check TypedSchema default ordering
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1398 +/- ##
==========================================
+ Coverage 52.98% 53.10% +0.12%
==========================================
Files 238 239 +1
Lines 13297 13368 +71
Branches 2723 2736 +13
==========================================
+ Hits 7045 7099 +54
- Misses 5356 5366 +10
- Partials 896 903 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| // I = expression type (recursive), S = selector type | ||
|
|
||
| /** Type cast expression */ | ||
| export interface ExprCast<I> extends |
There was a problem hiding this comment.
please comment out the expressions which are not supported by actual code jet, this one is the example, check others
There was a problem hiding this comment.
remove all unimplimented tyeps
There was a problem hiding this comment.
The main goal of this file is to serve as documentation, and thus readability is the main goal here. Let's just clearly write all the fields.
| /** Input expression (must evaluate to string) */ | ||
| input: I; | ||
| /** Regular expression pattern */ | ||
| value: string; |
There was a problem hiding this comment.
QueryStringRegexExtract will be nice
No description provided.