Minor fixes

[dbolotin]

No description provided.

[changeset-bot]

🦋 Changeset detected

Latest commit: 9ffe5da

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages

Name	Type
@platforma-sdk/model	Minor
@milaboratories/pf-driver	Patch
@milaboratories/pl-middle-layer	Patch
@milaboratories/uikit	Patch
@platforma-sdk/test	Minor
@platforma-sdk/ui-vue	Minor
@milaboratories/milaboratories.monetization-test.model	Patch
@milaboratories/milaboratories.monetization-test.ui	Patch
@milaboratories/milaboratories.ui-examples.model	Patch
@milaboratories/milaboratories.ui-examples.ui	Patch
@milaboratories/milaboratories.ui-examples	Patch
@milaboratories/milaboratories.pool-explorer.model	Patch
@milaboratories/milaboratories.pool-explorer	Patch
@milaboratories/milaboratories.pool-explorer.ui	Patch
@milaboratories/milaboratories.monetization-test	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[gemini-code-assist]

Summary of Changes

Hello @dbolotin, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the @platforma-sdk/model package by exposing previously internal types related to axis selectors with split functionality. The primary goal is to make these utility types available for broader use within the SDK, accompanied by a minor version increment to signify this API addition.

Highlights

• New Type Exports: This pull request introduces the export of AAxisSelectorWithSplit and similar types from the @platforma-sdk/model package, making them accessible for external consumption.
• Changeset Added: A new changeset file has been added, indicating a minor version bump for @platforma-sdk/model to reflect the new type exports.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds an export for new *WithSplit selector types. My review includes two suggestions for improvement. First, in the changeset file, I recommend making the description more specific by listing all the exported types for better release notes. Second, in index.ts, I suggest using a type-only export (export type * from ...) since the module being exported only contains types. This is a best practice in TypeScript for clarity and can aid build optimizations.

[gemini-code-assist]

The changeset message is a bit vague. For better clarity in the release notes, it would be helpful to list all the new types being exported instead of using 'and similar types'.

Suggested change

	Adding export of AAxisSelectorWithSplit and similar types
	Export `AAxisSelectorWithSplit`, `APColumnSelectorWithSplit`, `AxisSelectorWithSplit`, and `PColumnSelectorWithSplit` types

[gemini-code-assist]

Since split_selectors.ts only exports types, it's better to use a type-only export. This makes the intent clearer and can help with build tool optimizations.

Suggested change

	export * from './split_selectors';
	export type * from './split_selectors';