MILAB-5037: infrastructure cleanup (Google Cloud nightly tests)

[DenKoren]

No description provided.

[changeset-bot]

🦋 Changeset detected

Latest commit: 35808e7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[notion-workspace]

[blocks/mixcr-clonotyping] Google Cloud; error: failed to link indexed file to archive: no space left on device

[gemini-code-assist]

Summary of Changes

Hello @DenKoren, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on an infrastructure cleanup for Google Cloud nightly tests by refactoring the Helm chart configuration. It replaces a large, general-purpose values.yaml file with a new, dedicated ci-nightly-tests.yaml. This change aims to streamline the deployment process for nightly tests by providing a more concise and specific set of configurations, thereby improving clarity and maintainability.

Highlights

• Helm Chart Refactoring: The generic and comprehensive values.yaml file has been removed, indicating a shift towards more specialized configuration management.
• Dedicated Nightly Test Configuration: A new Helm values file, ci-nightly-tests.yaml, has been introduced. This file specifically tailors the deployment configuration for Google Cloud nightly tests, making the setup more focused and explicit.
• Streamlined Infrastructure Setup: The changes simplify the infrastructure setup for nightly tests by removing broad, default configurations and providing only the necessary parameters for these specific deployments.

Ignored Files

• Ignored by pattern: .github/workflows/** (1)
  • .github/workflows/test-k8s-nightly.yaml

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the Helm configuration for Google Cloud nightly tests by replacing a large, generic values.yaml with a more focused ci-nightly-tests.yaml. This is a positive change for maintainability. My review of the new configuration file has identified a few areas for improvement. Notably, there is a security vulnerability related to running containers with root privileges. I have also included suggestions to enhance the reproducibility and robustness of the configuration.