test-ci

[mike-ainsel]

No description provided.

[changeset-bot]

🦋 Changeset detected

Latest commit: ffacf98

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages

Name	Type
@milaboratories/build-configs	Patch
@milaboratories/ts-builder	Patch
@milaboratories/uikit	Patch
@platforma-sdk/ui-vue	Patch
@milaboratories/milaboratories.monetization-test.ui	Patch
@milaboratories/milaboratories.pool-explorer.ui	Patch
@milaboratories/milaboratories.monetization-test	Patch
@milaboratories/milaboratories.pool-explorer	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[gemini-code-assist]

Summary of Changes

Hello @mike-ainsel, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the ts-builder CLI by introducing a --use-sources flag, which provides fine-grained control over how module resolution handles the sources export condition. This ensures that build and serve processes, utilizing tools like Vite and Rollup, only apply the sources condition when explicitly requested, preventing unintended behavior. Additionally, it includes a minor but significant refactoring of a type definition in the PlAutocompleteMulti component to improve its generic capabilities and overall type safety.

Highlights

• New CLI Option: Introduced a --use-sources flag to the ts-builder CLI, allowing explicit control over the sources export condition during build and serve operations.
• Build Configuration Integration: Integrated the useSources logic into Rollup and Vite configurations, ensuring that the sources export condition is applied conditionally based on the new flag or USE_SOURCES environment variable.
• Command Execution Enhancement: Updated the command execution utility to support passing custom environment variables to child processes, facilitating the conditional application of USE_SOURCES.
• Type Definition Refactoring: Refactored the OptionsSearch interface within the PlAutocompleteMulti component to be generic and globally accessible, improving type safety and reusability, and exported it as PlAutocompleteMultiOptionsSearch.

Ignored Files

• Ignored by pattern: .github/workflows/** (1)
  • .github/workflows/build.yaml

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request introduces a new useSources option to the ts-builder CLI, allowing users to specify whether to use the 'sources' export condition for resolving packages during build and serve operations. This change impacts Rollup and Vite configurations, and the PlAutocompleteMulti component in the UI kit has been updated to correctly type its optionsSearch prop and export the OptionsSearch interface.

[gemini-code-assist]

There is a typo in 'customcudition'. It should be 'custom condition'.

Suggested change

	ts-builder ignore customcudition for build/serve without flag
	ts-builder ignore custom condition for build/serve without flag

[gemini-code-assist]

The OptionsSearch interface is defined within the <script lang="ts"> block, which is typically used for component options API. While it works, it's generally better practice to define interfaces that are intended for external use or prop types within the <script lang="ts" setup> block or in a separate .ts file for better organization and clarity, especially since it's being exported. However, given it's exported, moving it to a separate .ts file might be the cleanest approach.