Enable linter before type-check

[dbolotin]

No description provided.

[changeset-bot]

⚠️ No Changeset found

Latest commit: fbda31e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[gemini-code-assist]

Summary of Changes

Hello @dbolotin, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a change to the project's build configuration, specifically within the turbo.json file. The primary goal is to streamline the development workflow by ensuring that code linting is completed successfully before any type-checking processes are initiated. This adjustment helps in catching stylistic and potential quality issues earlier, leading to a more robust and consistent codebase.

Highlights

• Build Process Enhancement: The build configuration has been updated to ensure that the linter runs before the type-checker.
• Dependency Order: The type-check task in turbo.json now explicitly depends on the lint task, enforcing a sequential execution.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds the lint task as a dependency for the type-check task. This is a good change to ensure code is linted before type checking.

However, this change introduces some redundancy in the task dependency graph defined in turbo.json. I've added a specific comment to address the redundancy in the type-check task. I also noticed similar redundancies in other tasks which you might want to address in a follow-up to improve the configuration's clarity and maintainability:

• The build task depends on type-check, which now depends on lint and ^build. This makes the explicit ^build dependency in the build task redundant.
• The test task depends on build, which transitively depends on lint. This makes the explicit lint dependency in the test task redundant.