Unmarshalled PColumn bundle now inherit original resource reference and can be passed downstream to nested template

[dbolotin]

No description provided.

[changeset-bot]

🦋 Changeset detected

Latest commit: 876ed9d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages

Name	Type
@platforma-sdk/workflow-tengo	Minor
@milaboratories/pl-middle-layer	Patch
@milaboratories/milaboratories.monetization-test.workflow	Patch
@milaboratories/milaboratories.ui-examples.workflow	Patch
@milaboratories/milaboratories.pool-explorer.workflow	Patch
@platforma-sdk/test	Patch
@milaboratories/milaboratories.monetization-test	Patch
@milaboratories/milaboratories.ui-examples	Patch
@milaboratories/milaboratories.pool-explorer	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[gemini-code-assist]

Summary of Changes

Hello @dbolotin, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the functionality of PColumn bundles by implementing resource inheritance during their unmarshalling process. This crucial modification allows these bundles to retain their original resource context, making them fully compatible for downstream usage in nested templates and improving the overall flexibility and reusability of the workflow system.

Highlights

• Resource Inheritance: Unmarshalled PColumn bundles now inherit their original resource reference, ensuring proper context propagation.
• Nested Template Compatibility: This change enables PColumn bundles to be passed downstream and utilized effectively within nested templates.
• Bundle Creation Refinement: The ll.toStrict function is no longer used during PColumn bundle creation, and the oop module is now imported and used for inheritance.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a useful change by allowing the unmarshalled PColumn bundle to inherit properties from its original resource. This makes it possible to pass the bundle downstream to nested templates as if it were a resource itself. The implementation is straightforward. I've added one suggestion to inline the new inheritance logic to improve code locality, which is a minor structural improvement.

[gemini-code-assist]

While creating a new oop library for the inherit function is a valid approach, the inheritance logic is quite simple. Consider inlining it directly here to improve code locality and avoid introducing a new library file for a single function. This would make the logic easier to follow within the context of pColumnBundleUnmarshaller.

If you apply this suggestion, the oop import on line 9 will no longer be necessary.

			bundle["super"] = resource
			for k, v in resource {
				if is_undefined(bundle[k]) {
					bundle[k] = v
				}
			}
			return ll.toStrict(bundle)