Make country functions const
#15
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a use case where we'd like to maintain a static list of
countries to check some values against, e.g.:
We could just use the 3-letter codes, but it would be nice to have the
entire Country object for more flexibility (e.g. to check against
either 2-letter or 3-letter inputs), and without needing a workaround
like:
This PR updates the
countryandlookupmacros to enable constconstruction of
Countrytables, so that country construction can beused in const contexts.
In a second commit, I have updated the
constfunctions to use inlineconstblocks. This will guarantee that country resolution is alwaysevaluated at compile time, allowing the cost to be ~zero at runtime,
even outside of const contexts. This requires Rust 1.79, so I have
added a
rust-versionproperty toCargo.tomlto indicate the MSRV(released June, 2024). If you'd prefer to not add a feature requiring
an MSRV, let me know and I can drop that commit.