Stop parsing native object#46
Open
manobi wants to merge 4 commits intomikeal:masterfrom
manobi:master
Open
Conversation
Author
|
More tests show that it just happens when the design doc already exist in database. Can another people test if my modifications broke something for you ? Because I don't use the CLI command, I have some automated task in every project making: |
Owner
|
there was a bug in request for a few versions that were auto-parsing JSON for every repsonse. that has been fixed, but it may have been the real cause of this bug. but, we should change couchapp to use the builtin request json functionality rather than doing this decode inline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This still pushing apps to couchdb, but is outputing :
undefined:1
^
SyntaxError: Unexpected token o
at Object.parse (native)
I run tests and nothing broke.