ngp-piwik can use scope variable to populate attribute#14
Open
nittin4664 wants to merge 1 commit intomike-spainhower:masterfrom
Open
ngp-piwik can use scope variable to populate attribute#14nittin4664 wants to merge 1 commit intomike-spainhower:masterfrom
nittin4664 wants to merge 1 commit intomike-spainhower:masterfrom
Conversation
Owner
|
@nittin4664 Thank you for this PR! This looks quite useful, but could you rebase against the latest master and include at least a simple test? Thanks again! |
Owner
|
Also, please check out ocmments in #16 |
sgpatel5
approved these changes
Jul 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change enables the use of scope variable in the ngp-piwik attr. Which gives the flexibility of passing values rather then hardcoding it.