fix: HoverDelegateFactory may use a disposed InstantiationService

[sumimakito]

Description

Currently, getDefaultHoverDelegate and createInstantHoverDelegate are still used in many places across the codebase. While getDefaultHoverDelegate returns a lazy-initialized IScopedHoverDelegate, createInstantHoverDelegate calls the internally captured hoverDelegateFactory set by setHoverDelegateFactory to create an IScopedHoverDelegate.

After the StandaloneCodeEditor (created via monaco.editor.create) calls setHoverDelegateFactory on initialization, the StandaloneDiffEditor2 (created via monaco.editor.createDiffEditor) calls it a second time and overwrites it with a different HoverDelegateFactory. After the StandaloneDiffEditor2 is disposed, the last HoverDelegateFactory it set still captures a disposed InstantiationService, which causes an error upon use.

Fixes microsoft/monaco-editor#4612

Reproduction

Open in the Monaco Editor Playground

Monaco-Editor-Repro.mp4

[Copilot]

Pull request overview

This PR fixes a bug where the hover delegate factory could capture a disposed instantiation service, causing errors when hovering after a diff editor is disposed.

Key Changes:

• Changed setHoverDelegateFactory in StandaloneCodeEditor to use the singleton StandaloneServices.initialize({}) instead of the injected instantiationService parameter