Standardize the breadcrumb toggle option label (fix #257550) #284486
+20
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes the breadcrumb toggle option label to display "Breadcrumbs" instead of "Toggle Breadcrumbs" in context menus, addressing issue #257550.
- Added a
shortTitleproperty to the toggle breadcrumbs action - Updated the
toggled.titleto use the standardized "Breadcrumbs" label - Enabled short title rendering in the sticky scroll context menu
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/browser/parts/editor/breadcrumbsControl.ts | Added shortTitle property and updated toggled.title to use "Breadcrumbs" label for consistency |
| src/vs/editor/contrib/stickyScroll/browser/stickyScrollController.ts | Enabled renderShortTitle option in context menu to display the new short title format |
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
|
src/vs/workbench/contrib/notebook/browser/controller/layoutActions.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #257550
while avoiding changing how the command appears in Command Palette: