Skip to content

Conversation

@allancascante
Copy link
Contributor

@allancascante allancascante commented Dec 23, 2025

Description

Adding support to allow empty/blank password in connections; this will also require a change in STS (on this PR) to make the password field as optional. There are no UI changes, if user doesn't set the password and when connecting confirm it by not enter it, in the quick pick, the corresponding flag will be set to true.

This closes this issue: #20288

Code Changes Checklist

  • New or updated unit tests added
  • All existing tests pass (npm run test)
  • Code follows contributing guidelines
  • Telemetry/logging updated if relevant
  • No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

… to avoid asking for password moving forward
@github-actions
Copy link

github-actions bot commented Dec 23, 2025

PR Changes

Category Target Branch PR Branch Difference
vscode-mssql VSIX 5289 KB 5288 KB ⚪ -1 KB ( 0% )
sql-database-projects VSIX 5668 KB 5668 KB ⚪ 0 KB ( 0% )
data-workspace VSIX null KB 538 KB ⚪ 538 KB ( 0% )

@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.15%. Comparing base (1cf305d) to head (2b717c0).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20860      +/-   ##
==========================================
+ Coverage   66.13%   66.15%   +0.02%     
==========================================
  Files         210      210              
  Lines       20107    20108       +1     
  Branches     2618     2619       +1     
==========================================
+ Hits        13297    13302       +5     
+ Misses       6713     6708       -5     
- Partials       97       98       +1     
Files with missing lines Coverage Δ
...ensions/mssql/src/controllers/connectionManager.ts 52.07% <100.00%> (+0.69%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants