[jrl-cmakemodules] Add new port #49047
Open
+95
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤓 This is a prerequisite for adding the pinocchio port (#8928). The next step is to add the coal port, both of which will utilize jrl-cmakemodules.
🥵 As described in the usage, jrl-cmakemodules need to be imported before defining the project in CMake. However, my testing revealed that some vcpkg-related configurations only take effect after the project is defined. Therefore, I added
project(vcpkg_helper LANGUAGES NONE)at the beginning of the usage (I will add similar patches to CMakeLists.txt for coal and pinocchio later). I feel this is not a good approach. Is there a better way to write it?find_packagecalls are REQUIRED, are satisfied byvcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.jsonmatches what upstream says.vcpkg.jsonmatches what upstream says../vcpkg x-add-version --alland committing the result.