[whereami] Add new port #49023
Draft
[whereami] Add new port #49023
+120
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@microsoft-github-policy-service agree company="KDAB" |
Author
|
Upstream has no official version, used 0.0.1 |
BillyONeal
requested changes
Dec 23, 2025
| diff --git a/CMakeLists.txt b/CMakeLists.txt | ||
| new file mode 100644 | ||
| index 0000000..d4fba04 | ||
| --- /dev/null |
Member
There was a problem hiding this comment.
Since this is just adding 2 files directly, if the separate build system remains, can you just add them as files and file(COPY them into place in portfile.cmake rather than trying to do it as a patch?
| vcpkg_cmake_config_fixup(PACKAGE_NAME unofficial-whereami CONFIG_PATH "lib/cmake/unofficial-whereami") | ||
| vcpkg_install_copyright(FILE_LIST "${SOURCE_PATH}/LICENSE.MIT" "${SOURCE_PATH}/LICENSE.WTFPLv2") | ||
|
|
||
| if(EXISTS "${CURRENT_PACKAGES_DIR}/debug/include") |
Member
There was a problem hiding this comment.
Don't you know this without an exists check?
| file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/debug/include") | ||
| endif() | ||
|
|
||
| if(EXISTS "${CMAKE_CURRENT_LIST_DIR}/usage") |
Member
There was a problem hiding this comment.
We know there is a usage file. though in this case I think the autogenerated usage should be sufficient and the usage file should be removed.
| @@ -0,0 +1,17 @@ | |||
| { | |||
| "name": "whereami", | |||
| "version": "0.0.1", | |||
Member
There was a problem hiding this comment.
Can you point to where this version number comes from upstream?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
find_packagecalls are REQUIRED, are satisfied byvcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.jsonmatches what upstream says.vcpkg.jsonmatches what upstream says../vcpkg x-add-version --alland committing the result.