[vcpkg-make] Prevent error 'vcpkg_cmake_get_vars was passed extra arguments: ADDITIONAL_LANGUAGES' building icu

[swebb2066]

Fixes #47887
Fixes #47301

[dg0yt]

Invalid.
The problem is not the passing of an empty list to multiple value option LANGUAGES.
The problem is having installed an old version of port vcpkg_cmake_get_vars which doesn't know that option.
The solution is to update the installed port.

[swebb2066]

The problem is have installed an old version of port vcpkg_cmake_get_vars which doesn't know that option.

I was using the head of 'master' building qt_base.

Just checkout master and build icu to replicate.

[dg0yt]

But did you start with an up-to-date installation of host dependency vcpkg-cmake-get-vars?

vcpkg update

[swebb2066]

But did you start with an up-to-date installation of host dependency vcpkg-cmake-get-vars?

Yes

 .\vcpkg upgrade
git checkout master
git pull
.\vcpkg update
.\vcpkg install icu:x64-windows-release

[dg0yt]

Do you want to indicate that .\vcpkg update didn't suggest any updates?
The actual upgrade is done with

`.\vcpkg upgrade --no-dry-run`

(after reviewing the suggestions).

[dg0yt]

NB: This will still pass ADDITIONAL_LANGUAGES in many cases, and so it would still raise the same error if vcpkg_cmake_get_vars wouldn't understand that option.

ADDITIONAL_LANGUAGES with and without args passes CI without errors.
But old version of vcpkg-cmake-get-vars don't know the keyword and raise the error.

[dg0yt]

A direct use of the option is in port libffi.

[swebb2066]

It was in no way apparent from the upgrade list that qtbase (or icu) needs vcpkg_cmake_get_vars.

Is there no way for a package (like icu) to check the required version of vcpkg_xxxx is installed?

[dg0yt]

It was in no way apparent from the upgrade list that qtbase (or icu) needs vcpkg_cmake_get_vars.

True, but the update list is for showing updates, not for highlighting transitive dependencies. For dependencies, there is:

$ ./vcpkg depend-info icu
vcpkg-cmake: 
vcpkg-cmake-get-vars: vcpkg-cmake
vcpkg-make: vcpkg-cmake-get-vars
icu[tools]: vcpkg-cmake-get-vars, vcpkg-make

Is there no way for a package (like icu) to check the required version of vcpkg_xxxx is installed?

Not in a simple way.

In classic mode, version inforation from the manifests is not used, so a simple condition in the manifests wouldn't help. Basically, as it is tested in CI, all ports should use the version from the same commit in the registry. User may skip upgrading installed ports when updating their copy of the registry, but then things may break.

(In manifest mode, the builtin-baseline also selects versions from the same revision of the main registry. Upgrades are done automatically when changing the baseline, so this is almost a non-issue - at the price of long rebuilds.)

[BillyONeal]

Invalid. The problem is not the passing of an empty list to multiple value option LANGUAGES. The problem is having installed an old version of port vcpkg_cmake_get_vars which doesn't know that option. The solution is to update the installed port.

I agree

[BillyONeal]

@vicroms agrees so I'm going to close this. Thanks for your submission and sorry that the diagnostics aren't better :/