Skip to content

Conversation

@nikitalita
Copy link
Contributor

@nikitalita nikitalita commented Dec 20, 2025

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

Depends on #48995

Adds a port for libplacebo.

I am not sure which default features make sense for this; the build files in upstream state:

if not (components.get('vulkan') or components.get('opengl') or components.get('d3d11'))
  warning('Building without any graphics API. libplacebo built this way still ' +
          'has some limited use (e.g. generating GLSL shaders), but most of ' +
          'its functionality will be missing or impaired!')
endif

has_spirv = components.get('shaderc') or components.get('glslang')
needs_spirv = components.get('vulkan') or components.get('d3d11')
if needs_spirv and not has_spirv
  warning('Building without any GLSL compiler (shaderc, glslang), but with ' +
          'APIs required that require one (vulkan, d3d11). This build is very ' +
          'likely to be very limited in functionality!')
endif

So we need at least one renderer backend for this port to be any use at all, and the shader compiler dependencies are required for the renderer backends. I would appreciate advice on this.

@nikitalita
Copy link
Contributor Author

How do you download the build logs from the CI?

@dg0yt
Copy link
Contributor

dg0yt commented Dec 20, 2025

The link to the instruction is in the error message.

@nikitalita
Copy link
Contributor Author

nikitalita commented Dec 20, 2025

Depends on #48995

@BillyONeal
Copy link
Member

I am not sure which default features make sense for this;

In general due to https://learn.microsoft.com/vcpkg/contributing/maintainer-guide#default-features-should-enable-behaviors-not-apis most of the time there should be no default features.

@BillyONeal BillyONeal marked this pull request as draft December 23, 2025 22:37
@BillyONeal
Copy link
Member

Drafted due to legitimate build failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants