[ableton-link] Update to 3.1.5 #48997
Conversation
JoergAtGithub
force-pushed
the
abletonlink_3_1_5
branch
from
01d804f to
017f8c0
Compare
Disable builds of the command line tool linkhut for android
JoergAtGithub
force-pushed
the
abletonlink_3_1_5
branch
from
bbbc0a7 to
46b5e3a
Compare
| install_test_executable("hut" "LinkHut") | ||
| install_test_executable("hutsilent" "LinkHutSilent") | ||
|
|
||
| # We must not correct the CMake include path before build |
There was a problem hiding this comment.
This seems broken; the whole reason vcpkg_apply_patches is deprecated is because it does not completely clean things up between runs, so it's possible the patch has already been applied.
There was a problem hiding this comment.
I did not touch this code section in this PR. But note that the vcpkg_from_github PATCHES feature is not usable here, as the patch must not be applied before installation of the test executables.
There was a problem hiding this comment.
I did not touch this code section in this PR. But note that the vcpkg_from_github PATCHES feature is not usable here, as the patch must not be applied before installation of the test executables.
I'm saying as written that doesn't actually happen. What happens if the patch is applied before installing executables?
| + find_package(ALSA) | ||
| + find_package(portaudio CONFIG) | ||
| + if(ALSA_FOUND AND portaudio_FOUND) |
There was a problem hiding this comment.
| + find_package(ALSA) | |
| + find_package(portaudio CONFIG) | |
| + if(ALSA_FOUND AND portaudio_FOUND) | |
| + find_package(ALSA REQUIRED) | |
| + find_package(portaudio CONFIG REQUIRED) |
Dependencies need to be controlled explicitly.
There was a problem hiding this comment.
This would not work, because this CMakeLists.txt is used to build multiple features, but ALSA and portaudio are only a dependency for the hut feature, and only on Linux.
There was a problem hiding this comment.
Then that needs to be controlled by whether the feature is turned on, not based on whether alsa and/or pulseaudio happen to be installed first.
2 participants
./vcpkg x-add-version --alland committing the result.