-
Notifications
You must be signed in to change notification settings - Fork 25
fix: Add null checks in local-memory.ts to prevent role crash #438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Fixes microsoft/teams-sdk#2500 Fixes microsoft/teams-sdk#2503 - Add bounds check (len > 0) before accessing messages[0] - Add optional chaining for messages[0]?.role access - Add null guard and bounds check in collapse() loop - Prevents 'Cannot read properties of null (reading role)' crash Root cause: Array access without bounds checking when: 1. Messages array becomes empty during collapse 2. end index exceeds array bounds in collapse loop Co-authored-by: claude-swarm-agent <swarm@local>
- Tests for constructor, get, push, pop, values, where methods - Tests for collapse functionality with different strategies - Specific tests for null safety fixes: - Empty array access prevention - Optional chaining for messages[0].role - Bounds checking in collapse boundary detection All 21 tests pass with 81% coverage on local-memory.ts
|
Added comprehensive test suite for Test Coverage: 81% on local-memory.ts
All tests pass. 🎉 |
|
@hggzm please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Summary
Adds defensive null checks to prevent crashes when accessing message properties on empty or boundary arrays.
Changes
len > 0guard before array access in trim loop?.) formessages[0].roleaccesslast &&guard and bounds check in slice operationTesting
Fixes #2500, #2503