Deprecate Teams Controllers #281
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added [Obsolete] attribute to main Controller and all test classes in Microsoft.Teams.Apps.Tests.Activities. Suppressed CS0612 warnings for obsolete Controller registration in Program.cs. No functional changes; these updates clarify deprecation status. Add Deprecated.Controllers project and mark old controllers obsolete Created Deprecated.Controllers project targeting .NET 10.0 with Teams and DevTools integration, including a sample MainController. Updated solution file to include the new project. Added configuration and launch settings for local development. Marked existing Controller and Teams activity test classes as [Obsolete] in the main sample app, and suppressed obsolete warnings where necessary.
rido-min
commented
Jan 22, 2026
| WebApplication? webApp = builder as WebApplication; | ||
| ArgumentNullException.ThrowIfNull(webApp, nameof(builder)); | ||
|
|
||
| webApp.MapPost("/api/messages", async (HttpContext httpContext, AspNetCorePlugin plugin, CancellationToken cancellationToken) => |
Member
Author
There was a problem hiding this comment.
make sure we review this.
It was not strictly required this change to deprecate the TeamsController, but with the goal of removing the MVC/Controllers I decided to listen to /api/messages from a minimal API as well.
rido-min
commented
Jan 22, 2026
| _lifetime = lifetime; | ||
| } | ||
|
|
||
| [HttpPost("/api/messages")] |
Member
Author
There was a problem hiding this comment.
note /api/messages was also hardcoded here
rido-min
commented
Jan 22, 2026
| WebApplication? webApp = builder as WebApplication; | ||
| ArgumentNullException.ThrowIfNull(webApp, nameof(builder)); | ||
|
|
||
| webApp.MapPost("/api/messages", async (HttpContext httpContext, AspNetCorePlugin plugin, CancellationToken cancellationToken) => |
Member
Author
There was a problem hiding this comment.
we should expose a variable to configure api/messages
This was referenced Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request deprecates the legacy controller-based APIs in favor of Minimal APIs, removes related obsolete infrastructure, and introduces a new sample project to demonstrate the deprecated controller pattern. The main focus is to guide developers toward using Minimal APIs for Teams app development, while still providing backward compatibility and clear migration paths.
Key changes include:
Deprecation of Controller-based APIs:
TeamsControllerAttribute,App.AddController<T>, and relevant controller classes (such asMessageControllerandActivityController) with[Obsolete("Use Minimal APIs instead.")]to indicate deprecation and guide users to Minimal APIs. [1] [2] [3] [4] [5]Removal of Legacy Controller Infrastructure:
RemoveDefaultMessageControllerclass and all code that dynamically registers or manages legacy controllers inHostApplicationBuilderExtensions. This simplifies the registration pipeline and prepares the codebase for exclusive Minimal API usage. [1] [2] [3] [4] [5]Migration to Minimal APIs:
AspNetCorePlugin.Configureto map the/api/messagesendpoint directly using Minimal API routing, replacing the previous controller-based route.New Sample for Deprecated Controllers:
Deprecated.Controllersto demonstrate the legacy controller pattern, including a simpleMainController, configuration files, and launch settings. This serves as a reference for teams transitioning away from controllers. [1] [2] [3] [4] [5] [6] [7]Miscellaneous and Backward Compatibility: