Update UserAgent to use AssemblyFileVersion #238
Conversation
Changed version retrieval in UserAgent property from Assembly.GetExecutingAssembly().GetName().Version to ThisAssembly.AssemblyFileVersion for improved accuracy.
There was a problem hiding this comment.
Pull request overview
This pull request updates the version retrieval mechanism for the UserAgent property in the App class. The change replaces the reflection-based approach (Assembly.GetExecutingAssembly().GetName().Version?.ToString()) with a compile-time constant from Nerdbank.GitVersioning (ThisAssembly.AssemblyFileVersion).
Key Changes:
- Simplified version retrieval by using
ThisAssembly.AssemblyFileVersioninstead of runtime reflection - Leverages the Nerdbank.GitVersioning package already configured in the project
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Changed version retrieval in UserAgent property from Assembly.GetExecutingAssembly().GetName().Version to ThisAssembly.AssemblyFileVersion for improved accuracy.
This pull request makes a minor update to how the application version is determined for the
UserAgentstring. The code now usesThisAssembly.AssemblyFileVersioninstead of the executing assembly's version, which provides a more accurate and consistent version number.(Libraries/Microsoft.Teams.Apps/App.csL49-R49)