Skip to content

Conversation

@iclanton
Copy link
Member

Summary

Fixes #5439

Details

// Lockfile v9 always has "." in importers filed.
this.isWorkspaceCompatible =
this.shrinkwrapFileMajorVersion >= ShrinkwrapFileMajorVersion.V9
? this.importers.size > 1
: this.importers.size > 0;
does not correctly handle the edge case when a subspace has no projects. This PR fixes that.

How it was tested

Introduced a unit test and tested with the repro steps in the issue.

Impacted documentation

None.

@iclanton iclanton merged commit 745aec6 into microsoft:main Dec 24, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from Needs triage to Closed in Bug Triage Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

[rush] rush update/install fails when the default subspace has no packages on PNPM versions 9 and 10

2 participants