build: support meson build system #375

mochaaP · 2025-12-01T14:02:49Z

CMake feature parity:

Extra features:

Export pkgconfig target
clang-format support
Make fmtlib optional when building examples
Install documents to docdir

Tested on Fedora Linux 44 (gcc/clang/msvc-wine + ninja) and Windows 10 22H2 (msvc + vs2022).

mochaaP · 2025-12-01T14:03:16Z

@microsoft-github-policy-service agree

mingxwa

Thank you for the contribution! Adding Meson support is a great addition to make the library more accessible. However, I have some concerns regarding the maintenance of the build files and the CI configuration.

tests/meson.build

docs/meson.build

.github/workflows/meson.yml

mingxwa · 2025-12-02T14:43:22Z

.github/workflows/meson.yml

+        env: ${{ matrix.mode.extra_envs }}
+        run: |
+          meson test -C build-${{ matrix.flavor }} --timeout-multiplier 5 --print-errorlogs
+          meson test --benchmark -C build-${{ matrix.flavor }} --timeout-multiplier 5 --print-errorlogs


Executing benchmarks in the CI pipeline is generally not necessary for verification. Please remove the benchmark execution steps and only run the unit tests.

other workflows runs benchmarks, so I included this.

done in ce70232

mochaaP · 2025-12-02T17:07:09Z

Thank you for the extensive review. I will work on the changes later.

tests/meson.build

benchmarks/meson.build

tests/modules/meson.build

tools/meson.build

.github/workflows/meson.yml

meson.build

docs/meson.build

.github/workflows/meson.yml

benchmarks/meson.build

docs/example.cpp.in

docs/meson.build

Copilot

Pull request overview

This PR adds comprehensive Meson build system support to the project alongside the existing CMake setup. The implementation includes building the library, tests, benchmarks, and extracting examples from documentation, with support for C++20 modules and various compiler configurations.

Key changes:

Complete Meson build configuration with feature parity to CMake (modules, tests, benchmarks, examples)
Python automation scripts for test/benchmark discovery and documentation example extraction
GitHub Actions CI workflow for testing Meson builds across multiple platforms and compilers

Reviewed changes

Copilot reviewed 22 out of 23 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
`meson.build`	Main build configuration defining project metadata, compiler checks, dependencies, and library targets
`meson.options`	Build options for enabling/disabling tests, benchmarks, examples, modules, and freestanding support
`meson.format`	Code formatting configuration for Meson files
`tools/meson_extract_doctest.py`	Script to extract C++ code examples from markdown documentation
`tools/meson_autogen_tests.py`	Script to auto-generate test case lists from GTest JSON output
`tools/meson_autogen_doctest.py`	Script to auto-generate documentation example file lists
`tools/meson_autogen_benchmarks.py`	Script to auto-generate benchmark suite definitions
`tools/meson.build`	Build configuration to locate Python automation scripts
`tools/extract_example_code_from_docs.py`	Refactored script with type hints and improved structure for extracting code examples
`tests/meson.build`	Test suite configuration including standard, freestanding, and module tests
`tests/modules/meson.build`	C++20 modules-specific test configuration
`benchmarks/meson.build`	Benchmark suite configuration
`docs/meson.build`	Configuration for building and testing documentation examples
`docs/example.cpp.in`	Template file for generated example code
`subprojects/*.wrap`	Meson wrap files for external dependencies (googletest, google-benchmark, fmt)
`tests/proxy_reflection_tests.cpp`	Fixed test using more accurate type trait combination
`include/proxy/v4/proxy_fmt.h`	Added fmt v12+ compatibility check for wchar_t support
`.github/workflows/meson.yml`	CI workflow for testing Meson builds with various compilers and configurations
`.github/workflows/pipeline-ci.yml`	Updated main CI pipeline to include Meson workflow
`.github/workflows/pipeline-release.yml`	Fixed tar command argument ordering in release script
`.gitignore`	Added Meson build artifacts and Python cache to ignore list

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

tools/meson_extract_doctest.py

tools/meson_autogen_tests.py

tools/meson_autogen_doctest.py

tools/meson_autogen_benchmarks.py

meson.build

include/proxy/v4/proxy_fmt.h

mingxwa · 2025-12-06T13:50:30Z

.github/workflows/bvt-compatibility.yml

+      fail-fast: false
+      matrix:
+        compiler:
+          - {compiler: gcc, version: 13, modules: false}


Adding Meson compatibility tests seems unnecessary. This job targets compiler version coverage, and testing every toolchain combination isn't an effective use of resources.

done in 6dfbc08

matrix build caught libc++ 16 has incomplete format support and not exposed (_LIBCPP_HAS_NO_INCOMPLETE_FORMAT is defined). should we test the feature using __cpp_lib_format instead of __has_include(<format>)?

do we support incomplete implementations of std::format? our code requires at least libc++ >= 17, but std::format support is incomplete until libc++ 19 (thus __cpp_lib_format is not defined before that)

With specialization for libc++. Fixes compilation on libc++ 16-18 that has incomplete std::format support.

.github/workflows/bvt-appleclang.yml

.github/workflows/bvt-clang.yml

.github/workflows/bvt-compatibility.yml

mingxwa · 2025-12-07T14:59:27Z

subprojects/google-benchmark.wrap

@@ -0,0 +1,13 @@
+[wrap-file]
+directory = benchmark-1.8.4


Please align the version with CMake (1.9.4).

tests/meson.build

tools/extract_example_code_from_docs.py

mingxwa · 2025-12-07T15:06:04Z

tools/extract_example_code_from_docs.py

+
+    @dataclass(frozen=True)
+    class Args:
+        input_dir: Path


To avoid duplication, please invoke this script from docs/meson.build and iterate outputs.

mingxwa · 2025-12-07T15:07:19Z

meson.build

+)
+modules_interface_specs = {
+  'gcc': {
+    'flags': ['-fmodules', '-fdeps-format=p1689r5'] + (cxx.has_header_symbol(


Is -fdeps-format=p1689r5 still needed in GCC 15?

at least on my Red Hat GCC 15.2.1-4 + ninja 1.13.1.
I completely removed modules support for now, will add it back once I fix it upstream.

too many compiler-specific workarounds. waiting for better upstream support.

…benchmark on ci

… build benchmark on ci

mingxwa · 2025-12-21T05:11:37Z

.github/workflows/bvt-nvhpc.yml


+    # - name: install meson
+    #   # FIXME: install from upstream once https://github.com/mesonbuild/meson/pull/15353 is released
+    #   run: pipx install git+https://github.com/mesonbuild/meson@02b85a846629090a0c7f18e860bab0a10ea4349b


I noticed that this change was released in 1.10.0. Thanks for the update! However, when building locally with NVHPC, I encountered several errors. I haven't had a chance to investigate in detail yet, but it seems related to the configuration.

In our CMake setup, we explicitly declare fmt as a SYSTEM dependency to suppress compiler warnings from third-party code, which helps avoid build failures with NVHPC. Does Meson offer a similar mechanism to mark dependencies as system includes?

mochaaP force-pushed the mochaa branch 8 times, most recently from 911dd00 to 3f00088 Compare December 1, 2025 17:33

mochaaP mentioned this pull request Dec 1, 2025

msft_proxy4: new wrap mesonbuild/wrapdb#2537

Draft

mochaaP force-pushed the mochaa branch 6 times, most recently from fcf4cdf to 94cae03 Compare December 2, 2025 03:02

mingxwa requested changes Dec 2, 2025

View reviewed changes

mochaaP force-pushed the mochaa branch from 8ec7ad3 to 823cbfc Compare December 2, 2025 19:47

mingxwa requested changes Dec 5, 2025

View reviewed changes

tian-lt reviewed Dec 5, 2025

View reviewed changes

.github/workflows/meson.yml Outdated Show resolved Hide resolved

tian-lt reviewed Dec 5, 2025

View reviewed changes

benchmarks/meson.build Outdated Show resolved Hide resolved

docs/example.cpp.in Outdated Show resolved Hide resolved

docs/meson.build Outdated Show resolved Hide resolved

mingxwa requested a review from Copilot December 5, 2025 10:05

Copilot started reviewing on behalf of mingxwa December 5, 2025 10:06 View session

Copilot finished reviewing on behalf of mingxwa December 5, 2025 10:07

Copilot AI reviewed Dec 5, 2025

View reviewed changes

tian-lt reviewed Dec 5, 2025

View reviewed changes

meson.build Show resolved Hide resolved

mingxwa reviewed Dec 5, 2025

View reviewed changes

include/proxy/v4/proxy_fmt.h Outdated Show resolved Hide resolved

mochaaP force-pushed the mochaa branch 2 times, most recently from ee03832 to 201a753 Compare December 6, 2025 12:15

mochaaP force-pushed the mochaa branch 2 times, most recently from 4ed6e5e to efdefc3 Compare December 6, 2025 13:38

mochaaP requested a review from mingxwa December 6, 2025 13:39

mingxwa reviewed Dec 6, 2025

View reviewed changes

mochaaP force-pushed the mochaa branch 2 times, most recently from 4dc8332 to 8d0d90b Compare December 6, 2025 14:36

mochaaP added 4 commits December 6, 2025 22:40

ci: move meson ci tests into bvt workflows

124bce2

build/meson: support pgi compilers

32071d5

ci: remove meson from compatibility tests

df5bd1b

ci: run meson and cmake in one pass

f32138f

mochaaP force-pushed the mochaa branch from 8d0d90b to f32138f Compare December 6, 2025 14:40

mochaaP requested a review from mingxwa December 6, 2025 15:15

mochaaP force-pushed the mochaa branch 2 times, most recently from 984e89e to c02d4db Compare December 6, 2025 17:06

Test for std::format using __cpp_lib_format

886f11f

With specialization for libc++. Fixes compilation on libc++ 16-18 that has incomplete std::format support.

mochaaP force-pushed the mochaa branch from c02d4db to 886f11f Compare December 6, 2025 17:10

defaultactor mentioned this pull request Dec 7, 2025

Bazel support #379

Open

mingxwa requested changes Dec 7, 2025

View reviewed changes

mochaaP added 7 commits December 8, 2025 21:54

build/meson: remove module support

76e68d2

too many compiler-specific workarounds. waiting for better upstream support.

fixup! ci: add meson tests

09e7ef2

fixup! Test for std::format using __cpp_lib_format

5dd012d

build/meson: add test and benchmarks to all targets, only test build …

e5fad93

…benchmark on ci

fixup! Test for std::format using __cpp_lib_format

952456f

fixup! build/meson: add test and benchmarks to all targets, only test…

a740673

… build benchmark on ci

fixup! build/meson: add test and benchmarks to all targets, only test…

717c86d

… build benchmark on ci

mochaaP force-pushed the mochaa branch from 410450d to 717c86d Compare December 8, 2025 19:25

mochaaP added 3 commits December 9, 2025 03:25

build/meson: update fmt to 12.1.0

4744c25

fixup! tools: add python typings

2c7f068

fixup! build/meson: remove all autogen

0ad0d06

mingxwa reviewed Dec 21, 2025

View reviewed changes

build: support meson build system #375

Are you sure you want to change the base?

build: support meson build system #375

Uh oh!

Conversation

mochaaP commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mochaaP commented Dec 1, 2025

Uh oh!

mingxwa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mochaaP commented Dec 2, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mochaaP Dec 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mochaaP Dec 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

mochaaP commented Dec 1, 2025 •

edited

Loading

mochaaP Dec 6, 2025 •

edited

Loading

mochaaP Dec 6, 2025 •

edited

Loading