Add serverlogics to optional entities for graceful 404 handling#1494
Merged
amitjoshi438 merged 2 commits intomainfrom Feb 24, 2026
Merged
Add serverlogics to optional entities for graceful 404 handling#1494amitjoshi438 merged 2 commits intomainfrom
amitjoshi438 merged 2 commits intomainfrom
Conversation
…ling When adx_serverlogics table does not exist in an environment, the bulk entity fetch returns 404 and logs as ApiRequestFailure. Adding SERVERLOGICS to conditionalFolderEntities allows the existing graceful 404/400 handling in fetchFromDataverseAndCreateFiles to catch this and log an info-level OptionalEntityNotFound event instead. Telemetry shows 511 such errors from 219 users on v2.0.131 in the last 7 days, all from adx_serverlogics 404s. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
priyanshu92
approved these changes
Feb 24, 2026
amitjoshi438
deleted the
users/amitjoshi/serverlogics-optional-entity
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SERVERLOGICStoconditionalFolderEntitiesso that 404 responses fromadx_serverlogicsbulk fetch are handled gracefullyadx_serverlogicstable doesn't exist in an environment, the existing graceful handler infetchFromDataverseAndCreateFilesnow catches it and logs an info-levelOptionalEntityNotFoundevent instead of anApiRequestFailureerroradx_serverlogics— this change eliminates those errorsTest plan
npm run compile-web)npm run test-web-integration)adx_serverlogicstable does not exist in the environment🤖 Generated with Claude Code