Skip to content

Conversation

@justinchuby
Copy link
Collaborator

@justinchuby justinchuby commented Jan 13, 2026

Remove ParamSchema and replace it with the new OpSignature.

BC breaking

The param_schemas() methods are removed from Ops and ONNXFuntions.

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jan 13, 2026

Codecov Report

❌ Patch coverage is 81.81818% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.45%. Comparing base (65ebb01) to head (bfe7103).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
onnxscript/_internal/param_manipulation.py 65.38% 7 Missing and 2 partials ⚠️
...on_libs/tools/torch_lib/deduce_type_constraints.py 83.33% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2768      +/-   ##
==========================================
+ Coverage   70.20%   70.45%   +0.24%     
==========================================
  Files         227      228       +1     
  Lines       27313    27252      -61     
  Branches     2769     2759      -10     
==========================================
+ Hits        19176    19201      +25     
+ Misses       7188     7099      -89     
- Partials      949      952       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the ParamSchema class and its associated methods, replacing them with the new OpSignature system. This is a breaking change that removes the param_schemas() methods from Op and OnnxFunction classes.

Changes:

  • Removed ParamSchema class and all related helper functions from the codebase
  • Deleted the deduce_type_constraints module and its tests (which relied on param_schemas())
  • Updated parameter manipulation functions to use OpSignature instead of ParamSchema
  • Migrated all tests to use OpSignature with Parameter and AttributeParameter

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
onnxscript/values.py Removed ParamSchema from public exports
onnxscript/function_libs/tools/torch_lib/deduce_type_constraints_test.py Deleted test file that depended on param_schemas()
onnxscript/function_libs/tools/torch_lib/deduce_type_constraints.py Deleted module that used ParamSchema for type constraint deduction
onnxscript/_internal/values_test.py Removed tests for param_schemas() method
onnxscript/_internal/values.py Removed ParamSchema class definition and param_schemas() methods from Op and OnnxFunction
onnxscript/_internal/param_manipulation_test.py Updated tests to use OpSignature instead of ParamSchema
onnxscript/_internal/param_manipulation.py Migrated functions from ParamSchema to OpSignature, renamed function to tag_arguments_with_signature
onnxscript/_internal/evaluator.py Updated to use op_signature instead of param_schemas()
onnxscript/_internal/converter.py Updated to use op_signature instead of param_schemas()

justinchuby and others added 3 commits January 13, 2026 12:44
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@justinchuby justinchuby merged commit e45724c into main Jan 15, 2026
32 of 33 checks passed
@justinchuby justinchuby deleted the justinchu/remove-param-schema branch January 15, 2026 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

4 participants