-
Notifications
You must be signed in to change notification settings - Fork 98
Remove ParamSchema #2768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ParamSchema #2768
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2768 +/- ##
==========================================
+ Coverage 70.20% 70.45% +0.24%
==========================================
Files 227 228 +1
Lines 27313 27252 -61
Branches 2769 2759 -10
==========================================
+ Hits 19176 19201 +25
+ Misses 7188 7099 -89
- Partials 949 952 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes the ParamSchema class and its associated methods, replacing them with the new OpSignature system. This is a breaking change that removes the param_schemas() methods from Op and OnnxFunction classes.
Changes:
- Removed
ParamSchemaclass and all related helper functions from the codebase - Deleted the
deduce_type_constraintsmodule and its tests (which relied onparam_schemas()) - Updated parameter manipulation functions to use
OpSignatureinstead ofParamSchema - Migrated all tests to use
OpSignaturewithParameterandAttributeParameter
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| onnxscript/values.py | Removed ParamSchema from public exports |
| onnxscript/function_libs/tools/torch_lib/deduce_type_constraints_test.py | Deleted test file that depended on param_schemas() |
| onnxscript/function_libs/tools/torch_lib/deduce_type_constraints.py | Deleted module that used ParamSchema for type constraint deduction |
| onnxscript/_internal/values_test.py | Removed tests for param_schemas() method |
| onnxscript/_internal/values.py | Removed ParamSchema class definition and param_schemas() methods from Op and OnnxFunction |
| onnxscript/_internal/param_manipulation_test.py | Updated tests to use OpSignature instead of ParamSchema |
| onnxscript/_internal/param_manipulation.py | Migrated functions from ParamSchema to OpSignature, renamed function to tag_arguments_with_signature |
| onnxscript/_internal/evaluator.py | Updated to use op_signature instead of param_schemas() |
| onnxscript/_internal/converter.py | Updated to use op_signature instead of param_schemas() |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Remove ParamSchema and replace it with the new OpSignature.
BC breaking
The
param_schemas()methods are removed from Ops and ONNXFuntions.