Skip to content

Conversation

@justinchuby
Copy link
Collaborator

  • torch.prod: Does not preserve dimensions
  • aten::normal.float_float: May be called with more arguments

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby justinchuby enabled auto-merge (squash) January 10, 2026 04:04
@justinchuby justinchuby added the module: torchlib Related to the torch/aten function lib in development label Jan 10, 2026
@justinchuby justinchuby changed the title [torchlib] Two fixes [torchlib] Fix prod and normal.float_float Jan 10, 2026
@codecov
Copy link

codecov bot commented Jan 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.20%. Comparing base (f1ab7bb) to head (a4747c8).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2762   +/-   ##
=======================================
  Coverage   70.20%   70.20%           
=======================================
  Files         227      227           
  Lines       27312    27314    +2     
  Branches     2768     2769    +1     
=======================================
+ Hits        19174    19177    +3     
+ Misses       7190     7188    -2     
- Partials      948      949    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby justinchuby added the merge at lgtm Reviewers can merge when they approve label Jan 10, 2026
@justinchuby justinchuby merged commit 41f5019 into main Jan 10, 2026
32 of 33 checks passed
@justinchuby justinchuby deleted the justinchu/torchlib-prod branch January 10, 2026 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge at lgtm Reviewers can merge when they approve module: torchlib Related to the torch/aten function lib in development

Projects

Development

Successfully merging this pull request may close these issues.

3 participants