AdvLoggerPkg: Minor fix in DecodeUefiLog.py _GetNextMessageBlock() #813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mu-automation
bot
added
language:python
apop5
approved these changes
Jan 13, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/202502 #813 +/- ##
================================================
Coverage ? 4.71%
================================================
Files ? 36
Lines ? 4196
Branches ? 276
================================================
Hits ? 198
Misses ? 3996
Partials ? 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
os-d
approved these changes
Jan 13, 2026
The function calls `self._ReadMessageEntry()` to read the next message entry from the log file. That function can return `None` for the `MessageEntry` if it encounters an invalid signature. This function needs to handle that case properly to avoid trying to access fields of a `None` object, which would lead to an `AttributeError`. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
makubacki
force-pushed
the
adv_logger_decode_py_fix
branch
from
519bda8 to
327ff0c
Compare
kuqin12
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a minor issue that has been present in the script for a very long time.
The function calls
self._ReadMessageEntry()to read the next message entry from the log file. That function can returnNonefor theMessageEntryif it encounters an invalid signature.This function needs to handle that case properly to avoid trying to access fields of a
Noneobject, which would lead to anAttributeError.How This Was Tested
self._ReadMessageEntry()to enter the case where it returns(None, None)and verify theAttributeErrordoes not occur.Integration Instructions