AdvLoggerPkg: Fix AdvancedLogDumper HII initialization bug #812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apop5
approved these changes
Jan 13, 2026
os-d
approved these changes
Jan 13, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/202502 #812 +/- ##
================================================
Coverage ? 4.71%
================================================
Files ? 36
Lines ? 4196
Branches ? 276
================================================
Hits ? 198
Misses ? 3996
Partials ? 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Commit 005cfdd added HII support to AdvancedLogDumper but did not link UefiHiiServicesLib to the application. Running the EFI app will give an assert similar to the following: ``` INFO - ASSERT_EFI_ERROR (Status = Invalid Parameter) INFO - ASSERT [AdvancedLogDumper] AdvLoggerPkg\Application\AdvancedLogDumper\LogDumperCommon.c(337): !(((RETURN_STATUS)(Status)) >= 0x8000000000000000ULL) ``` UefiHiiServicesLib needs to be linked (added to the INF file) for gHiiDatabase to be initialized properly. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
makubacki
force-pushed
the
adv_logger_efi_app_fix
branch
from
50a78b8 to
51fc4a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Commit 005cfdd added HII support to AdvancedLogDumper but did not link UefiHiiServicesLib to the application.
Running the EFI app will give an assert similar to the following:
UefiHiiServicesLib needs to be linked (added to the INF file) for gHiiDatabase to be initialized properly.
How This Was Tested
AdvancedLogDumperEFI application before and after the changeIntegration Instructions