-
Notifications
You must be signed in to change notification settings - Fork 112
Adding advanced logger support for ARM's SEC phase #810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
os-d
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because you expect this to only be used by Peiless ARM64, I would consider naming this AdvancedLoggerLib/PeilessSecArm/... to make it clear. Or PeilessSecArm64 or PeilessSecAArch64.
Also, the README needs updating to describe this instance.
AdvLoggerPkg/Library/AdvancedLoggerLib/SecArm/AdvancedLoggerLib.c
Outdated
Show resolved
Hide resolved
AdvLoggerPkg/Library/AdvancedLoggerLib/SecArm/AdvancedLoggerLib.c
Outdated
Show resolved
Hide resolved
AdvLoggerPkg/Library/AdvancedLoggerLib/SecArm/AdvancedLoggerLib.c
Outdated
Show resolved
Hide resolved
AdvLoggerPkg/Library/AdvancedLoggerLib/SecArm/AdvancedLoggerLib.c
Outdated
Show resolved
Hide resolved
AdvLoggerPkg/Library/AdvancedLoggerLib/SecArm/AdvancedLoggerLib.c
Outdated
Show resolved
Hide resolved
AdvLoggerPkg/Library/AdvancedLoggerLib/SecArm/AdvancedLoggerLib.inf
Outdated
Show resolved
Hide resolved
AdvLoggerPkg/Library/AdvancedLoggerLib/SecArm/AdvancedLoggerLib.inf
Outdated
Show resolved
Hide resolved
AdvLoggerPkg/Library/AdvancedLoggerLib/SecArm/AdvancedLoggerLib.inf
Outdated
Show resolved
Hide resolved
AdvLoggerPkg/Library/AdvancedLoggerLib/SecArm/AdvancedLoggerLib.uni
Outdated
Show resolved
Hide resolved
Co-authored-by: Oliver Smith-Denny <osde@microsoft.com>
Co-authored-by: Oliver Smith-Denny <osde@microsoft.com>
This reverts commit 1484291.
Co-authored-by: Oliver Smith-Denny <osde@microsoft.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/202502 #810 +/- ##
================================================
Coverage ? 5.02%
================================================
Files ? 36
Lines ? 3940
Branches ? 242
================================================
Hits ? 198
Misses ? 3740
Partials ? 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
The current setup does not have the support of advanced logger if an ARM64 platform would like to start the logging into static buffer from SEC phase.
This change adds the support of this use case. The assumption is that the ARM64 platform will have a static carve out of the advanced log buffer and hands off to DXE phase directly, because PEI phase memory manager is not sophisticated enough to reserve carveout memory backed by DRAM and thus could run into memory corruption issues.
For details on how to complete these options and their meaning refer to CONTRIBUTING.md.
How This Was Tested
This is tested on QEMU SBSA PEI-less builds and booted to both UEFI shell and OS.
Integration Instructions
Add
AdvancedLoggerLib|AdvLoggerPkg/Library/AdvancedLoggerLib/SecArm/AdvancedLoggerLib.infto the library SEC phase.