Skip to content

Conversation

@kuqin12
Copy link
Contributor

@kuqin12 kuqin12 commented Jan 7, 2026

Description

The current setup does not have the support of advanced logger if an ARM64 platform would like to start the logging into static buffer from SEC phase.

This change adds the support of this use case. The assumption is that the ARM64 platform will have a static carve out of the advanced log buffer and hands off to DXE phase directly, because PEI phase memory manager is not sophisticated enough to reserve carveout memory backed by DRAM and thus could run into memory corruption issues.

For details on how to complete these options and their meaning refer to CONTRIBUTING.md.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

This is tested on QEMU SBSA PEI-less builds and booted to both UEFI shell and OS.

Integration Instructions

Add AdvancedLoggerLib|AdvLoggerPkg/Library/AdvancedLoggerLib/SecArm/AdvancedLoggerLib.inf to the library SEC phase.

Copy link
Contributor

@os-d os-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because you expect this to only be used by Peiless ARM64, I would consider naming this AdvancedLoggerLib/PeilessSecArm/... to make it clear. Or PeilessSecArm64 or PeilessSecAArch64.

Also, the README needs updating to describe this instance.

kuqin12 and others added 6 commits January 7, 2026 15:39
Co-authored-by: Oliver Smith-Denny <osde@microsoft.com>
Co-authored-by: Oliver Smith-Denny <osde@microsoft.com>
Co-authored-by: Oliver Smith-Denny <osde@microsoft.com>
@kuqin12 kuqin12 requested review from apop5 and makubacki January 8, 2026 00:37
@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2026

Codecov Report

❌ Patch coverage is 0% with 59 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release/202502@cdcee30). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...y/AdvancedLoggerLib/PeilessArm/AdvancedLoggerLib.c 0.00% 59 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##             release/202502    #810   +/-   ##
================================================
  Coverage                  ?   5.02%           
================================================
  Files                     ?      36           
  Lines                     ?    3940           
  Branches                  ?     242           
================================================
  Hits                      ?     198           
  Misses                    ?    3740           
  Partials                  ?       2           
Flag Coverage Δ
AdvLoggerPkg 5.02% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kuqin12 kuqin12 enabled auto-merge (squash) January 8, 2026 05:22
@kuqin12 kuqin12 merged commit fc05e0b into microsoft:release/202502 Jan 8, 2026
28 checks passed
@kuqin12 kuqin12 deleted the adv_sec_arm branch January 8, 2026 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants