igvm_c: clean up unused code and printf format warnings #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Maybe it could be useful to add |
Member
|
Did you want to add those to CFLAGS as part of this too? |
Contributor
Author
I wanted to hear from you first! I found the warnings using those flags |
Member
|
I think it would be great to add those to CFLAGS (sorry about the long delay, back from the holidays). Want to do that in this PR as well? Thanks! |
`test_igvm` and `dump_igvm` contained an unused function, unused variables and format specifier mismatch in printf. No functional changes. Signed-off-by: Luigi Leonardi <leonardi@redhat.com>
Add `Wall` and `Wextra` flags to CFLAGS. Signed-off-by: Luigi Leonardi <leonardi@redhat.com>
Contributor
Author
no worries! I added a new commit for the flags and rebased to latest main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_igvmanddump_igvmcontained an unused function, unused variables and format specifier mismatch in printf.No functional changes.