Skip to content

fix(build): remove draft flag that prevents release tag creation#533

Merged
agreaves-ms merged 1 commit intomainfrom
fix/release-please-draft-creates-no-tag
Feb 13, 2026
Merged

fix(build): remove draft flag that prevents release tag creation#533
agreaves-ms merged 1 commit intomainfrom
fix/release-please-draft-creates-no-tag

Conversation

@WilliamBerryiii
Copy link
Member

Description

Removed the "draft": true setting from release-please-config.json. Draft GitHub releases do not create git tags, which broke release-please's version anchoring. Without the prior version tag, release-please rescanned the full commit history, found an old breaking change, and incorrectly bumped from 2.3.0 to 3.0.0 instead of computing the next patch or minor version.

  • Removed "draft": true from the top-level config object in release-please-config.json
  • Future releases will be published immediately, creating the git tag that release-please uses to anchor subsequent version calculations

Related Issue(s)

Type of Change

Select all that apply:

Code & Documentation:

  • Bug fix (non-breaking change fixing an issue)
  • New feature (non-breaking change adding functionality)
  • Breaking change (fix or feature causing existing functionality to change)
  • Documentation update

Infrastructure & Configuration:

  • GitHub Actions workflow
  • Linting configuration (markdown, PowerShell, etc.)
  • Security configuration
  • DevContainer configuration
  • Dependency update

AI Artifacts:

  • Reviewed contribution with prompt-builder agent and addressed all feedback
  • Copilot instructions (.github/instructions/*.instructions.md)
  • Copilot prompt (.github/prompts/*.prompt.md)
  • Copilot agent (.github/agents/*.agent.md)
  • Copilot skill (.github/skills/*/SKILL.md)

Note for AI Artifact Contributors:

  • Agents: Research, indexing/referencing other project (using standard VS Code GitHub Copilot/MCP tools), planning, and general implementation agents likely already exist. Review .github/agents/ before creating new ones.
  • Skills: Must include both bash and PowerShell scripts. See Skills.
  • Model Versions: Only contributions targeting the latest Anthropic and OpenAI models will be accepted. Older model versions (e.g., GPT-3.5, Claude 3) will be rejected.
  • See Agents Not Accepted and Model Version Requirements.

Other:

  • Script/automation (.ps1, .sh, .py)
  • Other (please describe):

Testing

  • Validated JSON syntax of release-please-config.json after edit
  • Verified diff contains only the intended single-line removal of "draft": true,

Checklist

Required Checks

  • Documentation is updated (if applicable)
  • Files follow existing naming conventions
  • Changes are backwards compatible (if applicable)
  • Tests added for new functionality (if applicable)

Required Automated Checks

The following validation commands must pass before merging:

  • Markdown linting: npm run lint:md
  • Spell checking: npm run spell-check
  • Frontmatter validation: npm run lint:frontmatter
  • Link validation: npm run lint:md-links
  • PowerShell analysis: npm run lint:ps

Security Considerations

  • This PR does not contain any sensitive or NDA information
  • Any new dependencies have been reviewed for security issues
  • Security-related scripts follow the principle of least privilege

Additional Notes

Two manual follow-up actions are required after this PR merges:

  1. Publish the v2.3.0 draft release on GitHub to create the missing hve-core-v2.3.0 git tag that anchors future release-please runs
  2. Close PR chore(main): release hve-core 3.0.0 #532 (the incorrect 3.0.0 release PR) and delete its branch release-please--branches--main--components--hve-core

Without publishing the draft release, release-please will still fail to find the v2.3.0 version anchor even after this config fix lands on main.

🔧 - Generated by Copilot

- draft releases do not create git tags, breaking version anchoring
- release-please cannot find prior version without a tag
- causes full commit history rescan and incorrect major bump

🔧 - Generated by Copilot
@WilliamBerryiii WilliamBerryiii requested a review from a team as a code owner February 13, 2026 17:42
Copilot AI review requested due to automatic review settings February 13, 2026 17:42
@github-actions
Copy link

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes release automation by ensuring GitHub releases created via release-please are published immediately (not as drafts), so the corresponding git tag is created and future version calculations remain correctly anchored.

Changes:

  • Removed the top-level "draft": true setting from release-please-config.json.

@agreaves-ms agreaves-ms merged commit c8de0aa into main Feb 13, 2026
24 checks passed
@agreaves-ms agreaves-ms deleted the fix/release-please-draft-creates-no-tag branch February 13, 2026 17:44
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.34%. Comparing base (910fb8b) to head (bb502a8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #533      +/-   ##
==========================================
- Coverage   85.36%   85.34%   -0.03%     
==========================================
  Files          23       23              
  Lines        4475     4475              
==========================================
- Hits         3820     3819       -1     
- Misses        655      656       +1     
Flag Coverage Δ
pester 85.34% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

agreaves-ms pushed a commit that referenced this pull request Feb 13, 2026
🤖 I have created a release *beep* *boop*
---


##
[2.3.1](hve-core-v2.3.0...hve-core-v2.3.1)
(2026-02-13)


### 🐛 Bug Fixes

* **build:** remove draft flag that prevents release tag creation
([#533](#533))
([c8de0aa](c8de0aa))
* **workflows:** correct JSON output formatting in plugin discovery step
([#531](#531))
([910fb8b](910fb8b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: hve-core-release-please[bot] <254602402+hve-core-release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants