Updates for OneHotEncoder in newer SKL versions#696
Draft
Conversation
866422a to
6f18e25
Compare
Codecov Report
@@ Coverage Diff @@
## main #696 +/- ##
==========================================
+ Coverage 90.14% 90.15% +0.01%
==========================================
Files 80 80
Lines 4625 4674 +49
Branches 848 864 +16
==========================================
+ Hits 4169 4214 +45
- Misses 259 261 +2
- Partials 197 199 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working on #684
Prototype for ints works, simple strings work
todo: Some problem with the user issue example.
todo: More impl/testing for strings.
in progress