This repository was archived by the owner on Jun 13, 2024. It is now read-only.
Set limit_request_field_size to 0 within lms_gunicorn.py.j2 template …#112
Open
btelnes wants to merge 1 commit intoedx_master_04_18_2018from
Open
Set limit_request_field_size to 0 within lms_gunicorn.py.j2 template …#112btelnes wants to merge 1 commit intoedx_master_04_18_2018from
btelnes wants to merge 1 commit intoedx_master_04_18_2018from
Conversation
…to allow headers larger than 8190 bytes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do? Please provide some context
Sets limit_request_field_size to 0 within lms_gunicorn.py to allow unlimited header field sizes. This is necessary to fix a bug where the header size is greater than 8190, the hard limit for headers in Gunicorn versions less than 19.7.0 (version used in Open Edx Ficus is 0.17.4). This shouldn't pose a security risk since Nginx acts as a proxy to Gunicorn and restricts the header size to 16K in nginx.conf.
Where should the reviewer start?
lms_gunicorn.py.j2
How can this be manually tested? (brief repro steps)
Using Postman or another tool, craft a request to the lms with large cookies such the the header is greater than 8190 bytes
What are the relevant TFS items? (list id numbers)
Bug 102507
Definition of done:
Reminders BEFORE merging
Reminders AFTER merging
Configuration Pull Request
(For changes proposed to upstream)
Make sure that the following steps are done before merging