Skip to content

Conversation

@mrjmarcelo
Copy link
Contributor

Workers were not controlling the pending items to be executed, in tests with heavy load of orchestrations and activities it makes older items don't get priority to be finished first, so I implemented some "ORDER BY SequenceNumber ASC" on SQL queries that use limit 1 to get an item to be processed to get priority on execution and to be finished first.

@cgillum
Copy link
Member

cgillum commented Nov 12, 2025

@mrjmarcelo looks like some of the integration tests are failing.

"failed to query for orchestration work-items: SQL logic error: no such column: SequenceNumber (1)"

@mrjmarcelo
Copy link
Contributor Author

@microsoft-github-policy-service agree

@mrjmarcelo
Copy link
Contributor Author

Thanks, @cgillum , I will fix and let you know.

@mrjmarcelo
Copy link
Contributor Author

mrjmarcelo commented Nov 14, 2025

@cgillum , fixed.

@JonathanFejtek, I guess my solution fix one of the same issues that yours, but I've seen yours have more changes, so I think besides this issue, your solution fixes and imporoves more things, am I right? I tried to create one solution by myself, because your solution was requesting a confirmation from your side and you were without interact for some time, but if yours solve the same that mine and have more improvements, I guess we can follow with what will be merged first.

@cgillum
Copy link
Member

cgillum commented Nov 14, 2025

FYI @mrjmarcelo tests are still failing.

@mrjmarcelo
Copy link
Contributor Author

@cgillum , thanks, fixed, now all test cases will pass with 'ok'.

@mrjmarcelo
Copy link
Contributor Author

Great, @cgillum , can you tell me when it will be merged?

@cgillum cgillum merged commit 5caea6a into microsoft:main Nov 17, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants