-
Notifications
You must be signed in to change notification settings - Fork 57
Prioritize older instances and tasks #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@mrjmarcelo looks like some of the integration tests are failing.
|
|
@microsoft-github-policy-service agree |
|
Thanks, @cgillum , I will fix and let you know. |
|
@cgillum , fixed. @JonathanFejtek, I guess my solution fix one of the same issues that yours, but I've seen yours have more changes, so I think besides this issue, your solution fixes and imporoves more things, am I right? I tried to create one solution by myself, because your solution was requesting a confirmation from your side and you were without interact for some time, but if yours solve the same that mine and have more improvements, I guess we can follow with what will be merged first. |
|
FYI @mrjmarcelo tests are still failing. |
|
@cgillum , thanks, fixed, now all test cases will pass with 'ok'. |
|
Great, @cgillum , can you tell me when it will be merged? |
Workers were not controlling the pending items to be executed, in tests with heavy load of orchestrations and activities it makes older items don't get priority to be finished first, so I implemented some "ORDER BY SequenceNumber ASC" on SQL queries that use limit 1 to get an item to be processed to get priority on execution and to be finished first.