Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 23, 2025

Addresses feedback from #1394 to strengthen the loadPageSize() test validation. The original test only checked the return value wasn't -1, missing validation of actual page size properties.

Changes

  • Enhanced test assertions: Verify loadPageSize() returns a positive value and is a power of 2
  • Replaced basic check with two-part validation:
    1. assertThat(pageSize, Matchers.greaterThan(0L)) - ensures valid page size
    2. assertThat(pageSize & (pageSize - 1), Matchers.is(0L)) - confirms power-of-2 (typical: 4096)
// Before
assertNotEquals(room.loadPageSize(), -1L);

// After
long pageSize = room.loadPageSize();
assertThat(pageSize, Matchers.greaterThan(0L));
assertThat(pageSize & (pageSize - 1), Matchers.is(0L));

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: anod <171704+anod@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Dec 23, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • dl.google.com
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED -Xmx1536m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant -cp /home/REDACTED/.gradle/wrapper/dists/gradle-8.5-bin/5t9huq95ubn472n8rpzujfbqh/gradle-8.5/lib/gradle-launcher-8.5.jar -javaagent:/home/REDACTED/.gradle/wrapper/dists/gradle-8.5-bin/5t9huq95ubn472n8rpzujfbqh/gradle-8.5/lib/agents/gradle-instrumentation-agent-8.5.jar org.gradle.launcher.daemon.bootstrap.GradleDaemon 8.5 (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Update room version to 2.8.4 based on review feedback Enhance loadPageSize() test to verify valid page size Dec 23, 2025
Copilot AI requested a review from anod December 23, 2025 14:39
@anod anod marked this pull request as ready for review December 23, 2025 15:20
@anod anod requested a review from a team as a code owner December 23, 2025 15:20
@anod anod merged commit 07858ce into algavris/room-upgrade Dec 23, 2025
1 check passed
@anod anod deleted the copilot/sub-pr-1394 branch December 23, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants