Skip to content

fix: add encoding='utf-8' to file operations in task_centric_memory #7194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sean-Kenneth-Doherty wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −5
Open

fix: add encoding='utf-8' to file operations in task_centric_memory #7194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...src/autogen_ext/experimental/task_centric_memory/utils/chat_completion_client_recorder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ def __init__(
# Load the previously recorded messages and responses from disk.
self.logger.info("Replay mode enabled.\nRetrieving session from: " + self.session_file_path)
try:
with open(self.session_file_path, "r") as f:
with open(self.session_file_path, "r", encoding="utf-8") as f:
self.records = json.load(f)
except Exception as e:
error_str = f"\nFailed to load recorded session: '{self.session_file_path}': {e}"
Expand Down Expand Up @@ -211,7 +211,7 @@ def finalize(self) -> None:
# Create the directory if it doesn't exist.
os.makedirs(os.path.dirname(self.session_file_path), exist_ok=True)
# Write the records to disk.
with open(self.session_file_path, "w") as f:
with open(self.session_file_path, "w", encoding="utf-8") as f:
json.dump(self.records, f, indent=2)
self.logger.info("\nRecorded session was saved to: " + self.session_file_path)
except Exception as e:
Expand Down
6 changes: 3 additions & 3 deletions ...ackages/autogen-ext/src/autogen_ext/experimental/task_centric_memory/utils/page_logger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ def finalize(self) -> None:
# Write the hash and other details to a file.
hash_str, num_files, num_subdirs = hash_directory(self.log_dir)
hash_path = os.path.join(self.log_dir, "hash.txt")
with open(hash_path, "w") as f:
with open(hash_path, "w", encoding="utf-8") as f:
f.write(hash_str)
f.write("\n")
f.write("{} files\n".format(num_files))
Expand Down Expand Up @@ -386,7 +386,7 @@ def flush(self, finished: bool = False) -> None:
return
# Create a call tree of the log.
call_tree_path = os.path.join(self.log_dir, self.name + ".html")
with open(call_tree_path, "w") as f:
with open(call_tree_path, "w", encoding="utf-8") as f:
f.write(_html_opening("0 Call Tree", finished=finished))
f.write(f"<h3>{self.name}</h3>")
f.write("\n")
Expand Down Expand Up @@ -498,7 +498,7 @@ def flush(self) -> None:
Writes the HTML page to disk.
"""
page_path = os.path.join(self.page_logger.log_dir, self.index_str + ".html")
with open(page_path, "w") as f:
with open(page_path, "w", encoding="utf-8") as f:
f.write(_html_opening(self.file_title, finished=self.finished))
f.write(f"<h3>{self.file_title}</h3>\n")
for line in self.lines:
Expand Down