Skip to content

fix:多source的节点跳不到的问题，例如：agent p\u\e, p->u,p->e,u->e 在运行当中，p或u无法跳到e #6728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rxy007 wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

fix:多source的节点跳不到的问题，例如：agent p\u\e, p->u,p->e,u->e 在运行当中，p或u无法跳到e #6728

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...s/autogen-agentchat/src/autogen_agentchat/teams/_group_chat/_graph/_digraph_group_chat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,7 @@ async def update_message_thread(self, messages: Sequence[BaseAgentEvent | BaseCh

if self._activation[target][activation_group] == "all":
self._remaining[target][activation_group] -= 1
if self._remaining[target][activation_group] == 0:
if self._remaining[target][activation_group] >= 0:
Copy link

Copilot AI Jun 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition '>= 0' may allow the target node to be added to the ready queue before all required processing is complete. Consider revisiting this logic to verify if the intended condition should remain '== 0' to ensure that nodes are only activated when their remaining count is exactly zero.

Suggested change
if self._remaining[target][activation_group] >= 0:
if self._remaining[target][activation_group] == 0:

Copilot uses AI. Check for mistakes.
# If all parents are done, add to the ready queue.
self._ready.append(target)
# Track which activation group was triggered
Expand Down
Loading