-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix: improve error when extracted completion is not a list #463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AdithyaKotian
wants to merge
3
commits into
microsoft:main
Choose a base branch
from
AdithyaKotian:fix/trace-completion-type
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| # Handling Failed Rollouts | ||
|
|
||
| Rollouts may fail due to transient system issues such as network errors, timeouts or external service failures. | ||
|
|
||
| ## Retry behavior | ||
| - Rollout retries are configured via `RolloutConfig`, including settings such as `max_attempts`, retry conditions and timeouts. | ||
| - If a rollout fails and returns `None`, it still counts as an attempt and follows the configured retry limits. | ||
|
|
||
| ## Batch behavior | ||
| - Failed rollouts are handled at the individual rollout level. | ||
| - There is currently no built-in mechanism to a automatically skip an entire batch when multiple rollouts fail. | ||
|
|
||
| ## Best practices | ||
| - Retries are useful for transient failures (e.g. temporary network issues). | ||
| - If failures occur frequently, this usually indicates an infrastructure problem rather than an issue retries can fix. | ||
| - In such cases, it is recommended to address the underlying system issue instead of increasing retry limits. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert this as it's not related to this PR.