Skip to content

Validate input length in generate_id utility #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DunuraWitharama wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Validate input length in generate_id utility #460

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions agentlightning/utils/id.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,18 @@


def generate_id(length: int) -> str:
"""Generate a random ID of the given length.
"""Generate a random hexadecimal ID of the given length.

Args:
length: The length of the ID to generate.
length: The desired length of the generated ID. Must be a positive integer.

Returns:
A random ID of the given length.
A random hexadecimal ID string of the given length.

Raises:
ValueError: If length is not a positive integer.
"""
if length <= 0:
raise ValueError("length must be a positive integer")

return hashlib.sha1(uuid.uuid4().bytes).hexdigest()[:length]