Replace some git config calls with libgit2 #1897
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjcheetham
reviewed
Jan 14, 2026
GVFS/GVFS/CommandLine/CloneVerb.cs
Outdated
| { | ||
| bool trustPackIndexes = enlistment.GetTrustPackIndexesConfig(); | ||
| bool trustPackIndexes; | ||
| using (var repo = new LibGit2RepoInvoker(NullTracer.Instance, enlistment.WorkingDirectoryBackingRoot)) |
Member
There was a problem hiding this comment.
Why can we not use a JsonTracer here?
using JsonTracer tracer = new JsonTracer(GVFSConstants.GVFSEtwProviderName, "GVFSClone")
Contributor
Author
There was a problem hiding this comment.
That would create a new log file just for this one operation, which feels wrong.
Instead I've moved this load up a few lines so it can use the Clone tracer.
tyrielv
force-pushed
the
tyrielv/avoid-git-config-process
branch
from
06e7d5a to
80f5df6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in #1895, starting a new git process just to read config isn't great for performance.
This PR addresses the specific call introduced in #1895 as well as the call for "Trust pack indexes" that I introduced recently.