Skip to content

Conversation

Copy link

Copilot AI commented Sep 4, 2025

The release pipeline contained two PublishBuildArtifacts@1 tasks that were redundantly publishing NuGet packages:

  1. First task: Published all build artifacts from $(Build.ArtifactStagingDirectory) as 'FhirAnonymizerBuild'
  2. Second task: Published only NuGet packages from $(build.artifactStagingDirectory)/nupkgs as 'nuget'

The second task was redundant because:

  • The first publish task already includes ALL artifacts, including NuGet packages stored in the /nupkgs subdirectory
  • The Release stage only downloads and uses the 'FhirAnonymizerBuild' artifact
  • No other files in the codebase reference the separate 'nuget' artifact
  • Codebase search confirmed the 'nuget' artifact name only appears in release.yml

This appears to be legacy code from when there may have been separate processes that consumed only the NuGet packages. The removal simplifies the pipeline while maintaining all required functionality.

Changes:

  • Removed the duplicate publish task for NuGet artifacts (lines 103-108)
  • Updated display name from 'publish binary artifacts' to 'publish build artifacts' for clarity
  • Verified YAML syntax validity and confirmed builds still work correctly

Fixes #260.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: chrisribe <1999791+chrisribe@users.noreply.github.com>
Copilot AI changed the title [WIP] Duplicate publish tasks in release.yml ? Remove duplicate publish task for NuGet artifacts in release.yml Sep 4, 2025
Copilot AI requested a review from chrisribe September 4, 2025 14:49
@chrisribe
Copy link
Member

@josiahvinson was not sure about this as this is part of legacy and there could be an underlying reason we do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate publish tasks in release.yml ?

2 participants