Linux compiler fixes (GCC & CLANG) #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The eBPF programlets cannot be built with -fno-stack-protector, as they won't be linked to the supporting code, as it doesn't make sense in their context. Add -fno-stack-protector to the build_ebpf line so that they won't be built with this feature when the feature is enabled for the userland parts of the project.
The compiler complains that the value inside the labs(...) calls in both places in this commit is an unsigned value, and always unsigned. Move the value being subtracted to the right-hand-side as an addition, and remove the labs(...) calls that would always return true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the eBPF programlet compilation to add
-fno-stack-protectorsimilar to microsoft/SysmonForLinux#42Additionally, the compiler warnings identified two calls to
labs(...)that would always evaluate totruedue to them operating on anunsignedvalue. I modified the less-than comparison to move the subtracted value from the left-hand side to be an added value to the right-hand side, and removed thelabs(...)calls.