Fix remove condition in debian prerm #59
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
first part of issue was silently fixed in #62 (which is confusing, since this PR was before that PR). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current version gives error during remove/purge/upgrade:
/var/lib/dpkg/info/sysinternalsebpf.prerm: 4: [: remove: unexpected operatorthis is because of
==, it should be=for[command, see https://tldp.org/HOWTO/Bash-Prog-Intro-HOWTO-11.htmlthis was silently fixed in #62
but also
$1should be compared with correct value, likeremove/upgrade/etc, seehttps://www.debian.org/doc/debian-policy/ch-maintainerscripts.html
btw, you can also check some "reference" examples in your debian-based system:
cat /var/lib/dpkg/info/*.prerm|less, in case if you will need some more complicated logic for different package actions.