Skip to content

Conversation

@arudell
Copy link
Member

@arudell arudell commented Jan 23, 2026

This pull request introduces several improvements and refinements to the SDN health diagnostics PowerShell module, focusing on severity handling, summary display flexibility, and transcript management. The most significant changes are the addition of a new severity level, improved parameterization for summary output, and adjustments to transcript handling for clarity and correctness.

Severity and Health State Handling:

  • Added 'FAILURE' as a valid severity value alongside 'FAIL', standardized severity mapping to use 'Failure' internally, and updated all related logic to treat 'FAILURE' as the primary failure state throughout the health validation and summary reporting. [1] [2] [3]

Summary Display Control:

  • Introduced a new SkipSummaryDisplay switch parameter to the Debug-SdnFabricInfrastructure function, allowing users to optionally suppress the summary output in the console. Logic was updated to respect this flag when displaying results. [1] [2] [3]

Transcript Management:

  • Improved transcript handling by capturing the result of Start-Transcript and Stop-Transcript to $null to avoid unnecessary output, and moved the transcript stop and summary message to execute after all processing, ensuring the transcript captures the entire session. [1] [2]

These changes enhance the flexibility, clarity, and reliability of the SDN diagnostics script, making it easier to interpret results and control output during automated or manual runs.

Change type

  • Bug fix (non-breaking change)
  • Code style update (formatting, local variables)
  • New Feature (non-breaking change that adds new functionality without impacting existing)
  • Breaking change (fix or feature that may cause functionality impact)
  • Other

Checklist:

  • My code follows the style and contribution guidelines of this project.
  • I have tested and validated my code changes.

@arudell arudell requested a review from a team as a code owner January 23, 2026 22:24
@arudell arudell enabled auto-merge (squash) January 23, 2026 22:33
$Severity = 'Failure'
$foregroundColor = 'Red'
}
'FAILURE' {
Copy link

@andrwli andrwli Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider leaving a comment somewhere about the distinction between FAIL and FAILURE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants