Skip to content

Conversation

@arudell
Copy link
Member

@arudell arudell commented Jan 23, 2026

This pull request updates the health reporting logic in src/modules/SdnDiag.Health.psm1 to standardize the severity terminology from WARN to WARNING, improves the health validation output formatting, and enhances the overall health report summary for SDN diagnostics. The changes also add color-coded output and a clear report header/footer for better readability.

Severity and terminology standardization:

  • Changed all references and logic from WARN to WARNING for health test results, including allowed values and result aggregation in all relevant functions (New-SdnHealthTest, New-SdnRoleHealthReport, New-SdnFabricHealthReport, and all diagnostic functions). [1] [2] [3] [4] [5] [6] [7] [8] [9]

Reporting and output improvements:

  • Added a severity parameter to Write-HealthValidationInfo, which sets the output color based on severity and displays severity in the report. Output color is now dynamically set to yellow for WARNING and red for FAIL. [1] [2] [3] [4]
  • Implemented a formatted report header and footer, and a summary section showing tested roles, nodes, timestamp, and overall health state with color coding.

Logic enhancements:

  • Improved aggregation logic to ensure the worst-case health state is reflected (FAIL > WARNING > PASS) and summary is displayed accordingly.

Remediation and messaging:

  • Updated remediation messages for clarity and consistency, especially in adapter performance settings and DNS resolution failures. [1] [2]

These changes make the health reporting more consistent, readable, and user-friendly for diagnosing SDN environments.

image

Change type

  • Bug fix (non-breaking change)
  • Code style update (formatting, local variables)
  • New Feature (non-breaking change that adds new functionality without impacting existing)
  • Breaking change (fix or feature that may cause functionality impact)
  • Other

Checklist:

  • My code follows the style and contribution guidelines of this project.
  • I have tested and validated my code changes.

@arudell arudell requested a review from a team as a code owner January 23, 2026 01:04
@arudell arudell merged commit 4b1d28d into main Jan 23, 2026
8 checks passed
@arudell arudell deleted the set-warning-for-health-tests branch January 23, 2026 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants