Adds nullable to double schema conversions (#589)#628
Merged
baywet merged 7 commits intosupport/v1from Jan 2, 2025
Merged
Conversation
* Update double schema * Update integration file tests * Update release notes
baywet
requested review from
andrueastman,
danielmbaluka,
darrelmiller,
gavinbarron,
irvinesunday,
millicentachieng and
xuzhg
as code owners
… vscode Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Member
Author
|
this PR also ports #593 |
This was referenced Dec 24, 2024
5 tasks
andrueastman
reviewed
Jan 2, 2025
Contributor
andrueastman
left a comment
andrueastman
left a comment
There was a problem hiding this comment.
Just a suggestion on removing the property instead. Otherwise looks good from my end.
Signed-off-by: GitHub <noreply@github.com>
|
andrueastman
approved these changes
Jan 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
port of #589 to the v1 branch