Fix: Honor CancellationToken in DownloadModelWithProgressAsync #374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add ct.ThrowIfCancellationRequested() check at the start of download loop - Ensures cancellation is checked on every iteration for immediate response - Add unit test to verify OperationCanceledException is thrown on cancellation - Resolves issue where downloads continued to 100% despite cancel requests
|
Someone is attempting to deploy a commit to the MSFT-AIP Team on Vercel. A member of the Team first needs to authorize it. |
added 2 commits
January 7, 2026 18:37
- Add cancellation check after yielding progress for faster response - Improve test to simulate realistic mid-download cancellation - Add test for pre-cancelled token scenario - Update assertions to account for async pipeline behavior Fixes issue where downloads continue to 100% despite cancellation request
…o TaskCanceledException
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #365